[FFmpeg-devel] [PATCH] avutil/avstring: add av_strreplace API into avstring

Nicolas George george at nsup.org
Sat Apr 1 11:01:15 EEST 2017

Le primidi 11 germinal, an CCXXV, Steven Liu a écrit :
> I think just similar, not duplicating, and the simple functionality use
> BPrint maybe too complex.

Well, I will say it unambiguously:

Parts of this patch DO duplicate logic that we already have, and your
statement about BPrint being too complex is simply completely wrong.

Therefore, it was not acceptable as is and should not have been pushed.

Pushing while leaving only half a day to answer this was UNACCEPTABLE.
Do not ever do it again please.

Now, I will not insist on reverting, but I will demand that you make a
priority of simplifying this code.


  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170401/3bdbe9fd/attachment.sig>

More information about the ffmpeg-devel mailing list