[FFmpeg-devel] [PATCH 2/5] avcodec/h264: change some labels to be macro-local
Ronald S. Bultje
rsbultje at gmail.com
Thu Apr 6 18:11:09 EEST 2017
On Thu, Apr 6, 2017 at 10:22 AM, James Darnley <jdarnley at obe.tv> wrote:
> On 2017-04-05 13:41, Ronald S. Bultje wrote:
> > Hi,
> > On Tue, Apr 4, 2017 at 9:53 PM, James Darnley <jdarnley at obe.tv> wrote:
> >> The labels get stripped leading to (slightly) nicer disassembly from
> >> objdump.
> > [..]
> >> - jz .cycle%1end
> >> + jz %%skip
> > Can you preserve the leading dot? I don't mind the %%skip, but please
> > it .%%skip.
> That makes the patch pointless because those symbols don't get stripped.
> If you want the leading dot then I will drop this patch.
Oh I see, right...
So, yes, that has disadvantages as well as advantages. I don't really have
an opinion on it. So if nobody else does either, and you like it, I guess
you could commit it?
More information about the ffmpeg-devel