[FFmpeg-devel] [PATCH 1/4] ffmpeg: rename a variable.
michael at niedermayer.cc
Thu Apr 6 20:31:22 EEST 2017
On Thu, Apr 06, 2017 at 07:03:25PM +0200, Nicolas George wrote:
> Le septidi 17 germinal, an CCXXV, Michael Niedermayer a écrit :
> > Its a while ago i worked with this and the code changed since then
> > so maybe iam wrong but
> > pkt->duration is the duration of the frame encoded in that packet
> > that is not neccesarily the time between its dts and the next dts
> > (well it is for a lot of cases of course where its guranteed but ...)
> > example (mpeg1/mpeg2/mpeg4)
> > I P B P B
> > PTS 1 10 2 20 19
> > DTS 0 1 2 10 19
> > DUR 1 9 8 x 1
> > Its quite possible i made a mistake of course ...
> Well, I do not know about that, I always thought DTS was stupid anyway.
> My patch is not changing the DTS logic, only the name of a variable to
> reflect its usage in the current code and avoid conflict with the next
> patch. The next patch is the important one.
> If the DTS logic needs fixing and you (or anybody else) end up doing it,
> then the name of the variable can be fixed at the same time. And having
> "dts" in it will help finding it.
A comment explaining this (if you agree that the issue is real and not
some mistake of understanding something on my side)
would be a good idea.
could be confusing otherwise and lead to misunderstandings
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Asymptotically faster algorithms should always be preferred if you have
asymptotical amounts of data
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 181 bytes
Desc: Digital signature
More information about the ffmpeg-devel