[FFmpeg-devel] [PATCH 2/2] Add experimental support for Opus in ISO BMFF (MP4)

Matthew Gregan kinetik at flim.org
Fri Apr 7 07:29:36 EEST 2017


At 2017-04-05T20:43:21-0300, James Almer wrote:
> > +    /* OpusSpecificBox size plus magic for Ogg OpusHead header. */
> > +    size = atom.size + 16;
> 
> This should be 8. "OpusHead" is not 16 bytes.
> 
> > +    avio_read(pb, st->codecpar->extradata + 9, size - 17);
> 
> Same, this should be size - 9.

Oops, silly mistake there.  Thanks for the feedback!  Updated patch attached.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Add-experimental-demuxing-support-for-Opus-in-ISO-BM.patch
Type: text/x-diff
Size: 3074 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170407/358be005/attachment.patch>


More information about the ffmpeg-devel mailing list