[FFmpeg-devel] [PATCH] avutil/internal: Do not enable CHECKED with DEBUG

Ronald S. Bultje rsbultje at gmail.com
Fri Apr 7 19:58:50 EEST 2017


Hi,

On Fri, Apr 7, 2017 at 7:49 AM, Michael Niedermayer <michael at niedermayer.cc>
wrote:

> This avoids potential undefined behavior in debug mode while still allowing
> developers which want to check for potential additional overflows to do so
> by manually enabling this.
>
> Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> ---
>  libavutil/internal.h | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/libavutil/internal.h b/libavutil/internal.h
> index 7780a9a791..70ae37f859 100644
> --- a/libavutil/internal.h
> +++ b/libavutil/internal.h
> @@ -30,9 +30,8 @@
>  #    define NDEBUG
>  #endif
>
> -#if defined(DEBUG) && !defined(CHECKED)
> -#    define CHECKED
> -#endif
> +// This can be enabld to allow detection of additional integer overflows
> with ubsan
> +//#define CHECKED


s/enabld/enabled/.

Ronald


More information about the ffmpeg-devel mailing list