[FFmpeg-devel] [PATCH] avcodec/avcodec: Fix text implying single threaded decoding
michael at niedermayer.cc
Tue Apr 18 16:07:24 EEST 2017
On Tue, Apr 18, 2017 at 02:14:47PM +0200, wm4 wrote:
> On Tue, 18 Apr 2017 13:30:43 +0200
> Michael Niedermayer <michael at niedermayer.cc> wrote:
> > On Tue, Apr 18, 2017 at 06:43:07AM -0400, Ronald S. Bultje wrote:
> > > Hi,
> > >
> > > On Tue, Apr 18, 2017 at 6:31 AM, Michael Niedermayer <michael at niedermayer.cc
> > > > wrote:
> > >
> > > > Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> > > > ---
> > > > libavcodec/avcodec.h | 2 +-
> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
> > > > index ee133712b5..2ac1523a36 100644
> > > > --- a/libavcodec/avcodec.h
> > > > +++ b/libavcodec/avcodec.h
> > > > @@ -4960,7 +4960,7 @@ int avcodec_decode_subtitle2(AVCodecContext *avctx,
> > > > AVSubtitle *sub,
> > > > * Unlike with older APIs, the packet is always fully
> > > > consumed,
> > > > * and if it contains multiple frames (e.g. some audio
> > > > codecs),
> > > > * will require you to call avcodec_receive_frame()
> > > > multiple
> > > > - * times afterwards before you can send a new packet.
> > > > + * times afterwards.
> > >
> > >
> > > Does/did this imply single-threaded decoding?
> > if you cannot send a new packet before you received the output of
> > the previous then the decoder has only one packet at a time and cannot
> > decode multiple in parallel.
> > ill add above to the commit message
> That's not how it works. I'm against the patch.
Thats not how patch review works. If you have objections, you have to
explain the issue so it can be resolved/clarified.
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
I have never wished to cater to the crowd; for what I know they do not
approve, and what they approve I do not know. -- Epicurus
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 181 bytes
Desc: Digital signature
More information about the ffmpeg-devel