[FFmpeg-devel] [PATCH]lavf/mov: Only copy extradata if it exists.

[Michael Niedermayer]

On Tue, Apr 18, 2017 at 10:59:31AM +0200, Carl Eugen Hoyos wrote:
> Hi!
> 
> Attached patch fixes an ubsan warning like the following here:
> libavformat/mov.c:2332:13: runtime error: null pointer passed as argument 2, 
> which is declared to never be null
> 
> Please comment, Carl Eugen

>  mov.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 6e412b49316b5c6529c476233d54723c24b1d740  0001-lavf-mov-Only-copy-extradata-if-it-exists.patch
> From b117fdd2adf3271fcaf8f9388866aaf115284f74 Mon Sep 17 00:00:00 2001
> From: Carl Eugen Hoyos <cehoyos at ag.or.at>
> Date: Tue, 18 Apr 2017 10:56:31 +0200
> Subject: [PATCH] lavf/mov: Only copy extradata if it exists.
> 
> Avoids undefined call of memcpy(ptr, NULL, 0);
> ---
>  libavformat/mov.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

LGTM

thx

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Avoid a single point of failure, be that a person or equipment.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170418/74b24488/attachment.sig>