[FFmpeg-devel] [PATCH v2] avcodec/pthread_frame, decode: allow errors to happen on draining

[Nicolas George]

Le primidi 11 floréal, an CCXXV, James Almer a écrit :
> I don't think there's any explicit written rule about it, but in any
> case, both Ronald and wm4 had given him the ok for the patch he pushed,
> so waiting 24 hours after that is fine.
> 
> It could have waited a bit mainly because it's delicate code that could
> break badly if something is done wrong, so the more testing it's given
> the better.

I have not read the specifics of this thread, I do not think that
Muhammad did anything wrong here. I only react to the mail quoted
earlier:

https://lists.ffmpeg.org/pipermail/ffmpeg-devel/2017-March/208718.html

"No objections issues after 24hrs means patch is OK in FFmpeg
development."

This is just not true, and harmfully so.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170430/47577601/attachment.sig>