[FFmpeg-devel] [PATCH 07/14] lavfi/vf_overlay: use framesync2 options.

Michael Niedermayer michael at niedermayer.cc
Sat Aug 5 03:33:28 EEST 2017

On Wed, Aug 02, 2017 at 08:06:37AM +0200, Nicolas George wrote:
> Le quintidi 15 thermidor, an CCXXV, Michael Niedermayer a écrit :
> > removing these elements causes command lines using them to fail
> > for example:
> > 
> > ./ffmpeg -i matrixbench_mpeg2.mpg -i lena.pnm -filter_complex 'overlay=10:main_h-overlay_h-10:pass' -qscale 2 -t 1 file.avi
> Oh, the shorthand notation. The order of the non-essential options has
> changed in the past, including recently, and does not match the
> documentation,

The documentation says
@section overlay
@table @option
@item x
@item y
@item eof_action

Thats the order used in the example

Also either way
A user should be able to write a command line with filters from the
documentation and know if it will be supported in the future before
the future occurs and she finds out it stopped working.

> I have always considered it undocumented and as such
> unspecified.

> Moreover, with a separate object like that, keeping the order will be
> impossible: options added to the filter in the future will always come
> before the options in the framesync object.
> Therefore, I consider this minor break of compatibility acceptable. I
> should have mentioned it, but I forgot, sorry.
> What do other think?
> Regards,
> -- 
>   Nicolas George

> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

While the State exists there can be no freedom; when there is freedom there
will be no State. -- Vladimir Lenin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170805/a6be4bec/attachment.sig>

More information about the ffmpeg-devel mailing list