[FFmpeg-devel] [PATCHv3 4/4] libavcodec: v4l2: add support for v4l2 mem2mem codecs

Jorge Ramirez jorge.ramirez-ortiz at linaro.org
Mon Aug 7 22:18:13 EEST 2017

On 08/03/2017 01:53 AM, Mark Thompson wrote:
>> +        return ret;
>> +    }
>> +
>> +    av_log(log_ctx, AV_LOG_INFO, "Using device %s\n", tmpbuf);
>> +    ret = probe_and_set(s, log_ctx, 1);
>> +    s->devname = devname_save;
> This probing structure feels very fragile and possibly harmful (opening random devices and poking them).  It might be better to just force the user to supply the right device path?
>> +
I cleaned it up on v4 but I dont think it can be done much differently: 
the user needs to query the capabilities of every /dev/videoX node..

btw the same probing is already done in  libavdevice/v4l2.c

More information about the ffmpeg-devel mailing list