[FFmpeg-devel] [PATCH] avfilter: Add vmaf filter

[Michael Niedermayer]

On Thu, Aug 24, 2017 at 07:35:41AM +0530, Ashish Pratap Singh wrote:
> On Aug 24, 2017 05:13, "Michael Niedermayer" <michael at niedermayer.cc> wrote:
> 
> On Thu, Aug 24, 2017 at 12:58:53AM +0530, Ashish Pratap Singh wrote:
> > From: Ashish Singh <ashk43712 at gmail.com>
> >
> > Hi, this is vmaf filter. It fuses the scores of previous metrics adm,
> motion and vif
> > using svm algorithm. It's different from libvmaf filter because it has a
> very little
> > external dependency (only one svm model file).
> > Currently it supports only one model which can be extended later for
> other models.
> > I have added the model file inside libavfilter/data/ so that it can run
> successfully.
> > There is still a bit of work left to do like changing each filter from
> float
> > to integer. It's in progress along with SIMD optimizations.
> >
> > Signed-off-by: Ashish Singh <ashk43712 at gmail.com>
> > ---
> >  Changelog                              |   1 +
> >  doc/filters.texi                       |  38 ++
> >  libavfilter/Makefile                   |   1 +
> >  libavfilter/allfilters.c               |   1 +
> >  libavfilter/data/vmaf_v0.6.1.pkl.model | 218 ++++++++
> >  libavfilter/vf_vmaf.c                  | 945
> +++++++++++++++++++++++++++++++++
> >  libavfilter/vmaf.h                     | 138 +++++
> >  7 files changed, 1342 insertions(+)
> >  create mode 100644 libavfilter/data/vmaf_v0.6.1.pkl.model
> >  create mode 100644 libavfilter/vf_vmaf.c
> >  create mode 100644 libavfilter/vmaf.h
> 
> fails to build
> 
> CC      libavfilter/vf_vmaf.o
> libavfilter/vf_vmaf.c:36:17: fatal error: adm.h: No such file or directory
>  #include "adm.h"
>                  ^
> compilation terminated.
> make: *** [libavfilter/vf_vmaf.o] Error 1
> make: Target `all' not remade because of errors.
> 
> 
> 
> 
> [...]
> 
> 
> Hi, it requires adm, vmafmotion and vif filters (earlier patches) to be
> applied first.

please mention dependancies in the future in patch submissions that
dont contain these dependancies

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is dangerous to be right in matters on which the established authorities
are wrong. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170824/8c92a500/attachment.sig>