[FFmpeg-devel] [PATCH] Implement NewTek NDI support

[Marton Balint]

On Wed, 23 Aug 2017, Maksym Veremeyenko wrote:

> 22.08.2017 23:14, Maksym Veremeyenko пише:
> [...]
>>> One more thing I noticed testing, maybe you can take a look: rgba and 
>>> rgb0 format is not working (I used the V1 SDK), only audio frames are 
>>> received, but no apparent error is shown. On the other hand, bgr0 and 
>>> bgra formats do work. If you can't fix it then rgba and rgb0 formats 
>>> should be removed from the supported formats. Also please make the 
>>> docs in sync with the format support changes, I think it now only 
>>> mentions uyvy422.
>> i think it is related to:
>> 
>> +    /* Create receiver description */
>> +    recv_create_desc.color_format = NDIlib_recv_color_format_e_UYVY_RGBA;
>> +    recv_create_desc.bandwidth = NDIlib_recv_bandwidth_highest;
>> +    recv_create_desc.allow_video_fields = ctx->allow_video_fields;
>> 
>> i will try to check against v1 and v3 SDK...
>> 
>
> it is not related to code above. it seems a bug in v1.
>
> not working with v1:
>
> ffmpeg -loop 1 -r 25 -i /usr/local/src/NDI/NDI.Image.png -vf 
> "format=pix_fmts=bgr0" -f libndi_newtek -y png_bgr0
> ffmpeg -loop 1 -r 25 -i /usr/local/src/NDI/NDI.Image.png -vf 
> "format=pix_fmts=bgra" -f libndi_newtek -y png_bgra
> ffmpeg -f lavfi -i "testsrc=size=1920x1080:rate=25" -vf 
> "format=pix_fmts=rgb0" -f libndi_newtek -y testsrc_rgb0
> ffmpeg -f lavfi -i "testsrc=size=1920x1080:rate=25" -vf 
> "format=pix_fmts=rgba" -f libndi_newtek -y testsrc_rgba

Ok. If it works in v3, then I guess it is OK to apply as is. Let me know 
when you want me to do that.

Thanks,
Marton