[FFmpeg-devel] [PATCH 5/6] avformat/asfdec: Fix DoS due to lack of eof check

[Michael Niedermayer]

On Fri, Aug 25, 2017 at 08:52:22AM +0200, Paul B Mahol wrote:
> On 8/25/17, Michael Niedermayer <michael at niedermayer.cc> wrote:
> > From: ****** and *********(******) <tony.sh and wangchu.zhl at alibaba-inc.com>
> >
> > Fixes: loop.asf
> >
> > Found-by: Xiaohei and Wangchu from Alibaba Security Team
> > Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> > ---
> >  libavformat/asfdec_f.c | 9 ++++++++-
> >  1 file changed, 8 insertions(+), 1 deletion(-)
> >
> > diff --git a/libavformat/asfdec_f.c b/libavformat/asfdec_f.c
> > index be09a92bd1..00dd5ec41d 100644
> > --- a/libavformat/asfdec_f.c
> > +++ b/libavformat/asfdec_f.c
> > @@ -749,13 +749,20 @@ static int asf_read_marker(AVFormatContext *s, int64_t
> > size)
> >      count = avio_rl32(pb);    // markers count
> >      avio_rl16(pb);            // reserved 2 bytes
> >      name_len = avio_rl16(pb); // name length
> > -    for (i = 0; i < name_len; i++)
> > +    for (i = 0; i < name_len; i++) {
> > +        if (avio_feof(pb))
> > +            return AVERROR_INVALIDDATA;
> >          avio_r8(pb); // skip the name
> 
> This is very slow way to skip something.

yes, you are correct, i will fix that and resubmit

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If you think the mosad wants you dead since a long time then you are either
wrong or dead since a long time.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170825/5171b334/attachment.sig>