[FFmpeg-devel] [PATCH] avfilter/af_amix: switch to activate

[Michael Niedermayer]

On Sat, Aug 26, 2017 at 10:22:38PM -0300, James Almer wrote:
> On 8/26/2017 9:59 PM, Michael Niedermayer wrote:
> > On Sat, Aug 26, 2017 at 05:53:18PM +0200, Paul B Mahol wrote:
> >> Really fixes hangs and infinite loops.
> >>
> >> Signed-off-by: Paul B Mahol <onemda at gmail.com>
> >> ---
> >>  libavfilter/af_amix.c | 161 +++++++++++++++++++++++++-------------------------
> >>  1 file changed, 81 insertions(+), 80 deletions(-)
> > 
> > This breaks fate:
> > 
> > stddev:      0.00 PSNR:inf MAXDIFF:         0 bytes:  2116800/  1056768
> > size: |2116800 - 1056768| >= 0
> > stddev:      0.00 PSNR:inf MAXDIFF:         0 bytes:  2116800/   704512
> > size: |2116800 - 704512| >= 0
> > TEST    filter-hdcd-s16p
> > Test filter-amix-simple failed. Look at tests/data/fate/filter-amix-simple.err for details.
> > make: *** [fate-filter-amix-simple] Error 134
> > make: *** [fate-filter-amix-transition] Error 134
> 
> What system? FATE looks clean.

nothing special just normal ubuntu x86-64

i tool a closer look and it dies here:
Assertion !link->status_in failed at libavfilter/avfilter.c:1639
Aborted (core dumped)
make: *** [fate-filter-amix-simple] Error 134

thats a av_assert1(), i built with --assert-level=2

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Rewriting code that is poorly written but fully understood is good.
Rewriting code that one doesnt understand is a sign that one is less smart
then the original author, trying to rewrite it will not make it better.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170827/dd735367/attachment.sig>