[FFmpeg-devel] [PATCH] libavformat/dv : read dv audio as BE

Carl Eugen Hoyos ceffmpeg at gmail.com
Mon Aug 28 19:42:28 EEST 2017

2017-08-28 18:22 GMT+02:00 Александр Слободенюк
<alexander.slobodeniuk at bramtech.ru>:
> Fixing the FIXME issue, where BE audio inside the dv codec reads as LE
> after swapping it's bytes. It's was not very clear, because if we read
> it on BE machine we'll swap it twice.

> -static int dv_extract_audio(const uint8_t *frame, uint8_t **ppcm,
> +static int dv_extract_audio(const uint8_t *frame, uint16_t **ppcm,

Is this change necessary?
If not (I believe so) remove it, it makes the patch smaller.

> -            c->ast[i]->codecpar->codec_id   = AV_CODEC_ID_PCM_S16LE;
> +            c->ast[i]->codecpar->codec_id   = AV_CODEC_ID_PCM_S16BE;

This needs a micro version bump.

Carl Eugen

More information about the ffmpeg-devel mailing list