[FFmpeg-devel] [PATCH] Use NULL_IF_CONFIG_SMALL for AVOption tables.

wm4 nfxjfg at googlemail.com
Mon Aug 28 23:38:34 EEST 2017


On Mon, 28 Aug 2017 13:28:16 -0700
Dale Curtis <dalecurtis at chromium.org> wrote:

> On Mon, Aug 28, 2017 at 12:56 PM, wm4 <nfxjfg at googlemail.com> wrote:
> >
> > LTO seems unlikely to help in this situation - the linker can't know
> > whether struct members and their initializers are unused.
> >  
> 
> Correct.
> 
> 
> >
> > But I think there's much much bigger fish to fry to save space. For
> > example, I bet disabling unneeded codecs will significantly reduce
> > binary size.  
> 
> 
> I think the fish to fry depend on your configuration settings :) Chrome
> disables everything we can already.
> 
> Seems there's consensus that folk don't like the patch, we can carry it
> downstream if that's the case. It's not as much as I hoped, so we may drop
> it as well though.

Well, I agree that it would be nice if the binary size of the libs
would be smaller. How much do you expect to save? Saving 12KB of binary
size with a 200KB patch is just not convincing.

A less realistic approach would be to remove the field from AVOption
completely, and have the CLI programs (ffmpeg.c etc.) use a different
mechanism for getting per-option help strings. But that probably won't
happen for multiple reasons.


More information about the ffmpeg-devel mailing list