[FFmpeg-devel] [PATCH] avfilter: add ADM filter

[Ronald S. Bultje]

Hi,

On Thu, Aug 31, 2017 at 1:31 PM, Nicolas George <george at nsup.org> wrote:

> Le quartidi 14 fructidor, an CCXXV, Ashish Pratap Singh a écrit :
> > From: Ashish Singh <ashk43712 at gmail.com>
> >
> > Hi,
> > This patch changes adm filter from dualinput to framesync2.
> >
> > Signed-off-by: Ashish Singh <ashk43712 at gmail.com>
> > ---
> >  Changelog                |   1 +
> >  doc/filters.texi         |  15 +
> >  libavfilter/Makefile     |   1 +
>
> >  libavfilter/adm.h        |  75 +++++
>
> Can you explain the rationale for a separate header?
>
> As far as I can see, you are declaring static variables in it, which is
> almost always wrong, and a function that is only used once and could be
> static (and if not, needs the ff_ namespace).


The "native" vmaf filter will use this to call adm internally. It probably
needs to use the ff_ namespace, yes.

Ronald