[FFmpeg-devel] [PATCH][RFC] avutil/reverse: make ff_reverse shared

Nicolas George george at nsup.org
Fri Dec 1 10:42:42 EET 2017


James Almer (2017-11-30):
> Signed-off-by: James Almer <jamrial at gmail.com>
> ---
> Pros:
> Removes duplicate arrays and ugly c file including c files
> 
> Cons:
> Makes the array in libavutil effectively part of the ABI.
> Might not be worth doing for 256 bytes
> 
> 
> Something like this was probably sent before, so i guess it
> will be rejected again.

I think it is worse than that: the opposite was done on purpose.

I believe the rationale was that shared data object do not work
correctly with shared libraries on windows.

IMHO, it is yet another argument for merging the libraries.

(And to drop windows support. Only kidding.)

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20171201/7cc09127/attachment.sig>


More information about the ffmpeg-devel mailing list