[FFmpeg-devel] [PATCH] avfilter/formats: fix wrong function name in error message

Michael Niedermayer michael at niedermayer.cc
Mon Dec 4 20:32:49 EET 2017


On Mon, Dec 04, 2017 at 11:07:11AM +0100, Hendrik Leppkes wrote:
> On Mon, Dec 4, 2017 at 10:53 AM, Moritz Barsnick <barsnick at gmx.net> wrote:
> > On Mon, Dec 04, 2017 at 13:02:20 +0800, Jun Zhao wrote:
> >> Use perdefined micro __FUNCTION__ rather than hard coding function name
> >> to fix wrong function name in error message.
> >
> > AFAICT, "__FUNCTION__" is a C99 feature and thereby not supported by
> > ffmpeg style. Or should it be? (It might be "supported by all compilers
> > we care about".)
> >
> > http://ffmpeg.org/developer.html#C-language-features
> >
> 
> __FUNCTION__ is not C99, its a compiler extension (which is understood
> by GCC and some other compilers). __func__ is the C99 keyword.
> Its likely that not all compilers we currently support would have
> __func__, if they all have __FUNCTION__ however I cannot tell.

There are some matches for __FUNCTION__ in git, so i wonder if all
compilers we support do support it

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Concerning the gods, I have no means of knowing whether they exist or not
or of what sort they may be, because of the obscurity of the subject, and
the brevity of human life -- Protagoras
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20171204/7eca9c1e/attachment.sig>


More information about the ffmpeg-devel mailing list