[FFmpeg-devel] [PATCH 1/2] vaapi_h264: Add named options for setting profile and level

Mark Thompson sw at jkqxz.net
Tue Dec 5 01:34:03 EET 2017


On 04/12/17 05:25, Li, Zhong wrote:
>> From: ffmpeg-devel [mailto:ffmpeg-devel-bounces at ffmpeg.org] On Behalf
>> Of Mark Thompson
>> Sent: Saturday, December 2, 2017 11:36 PM
>> To: ffmpeg-devel at ffmpeg.org
>> Subject: Re: [FFmpeg-devel] [PATCH 1/2] vaapi_h264: Add named options for
>> setting profile and level
>>
>> On 01/12/17 05:24, Li, Zhong wrote:
>>>> From: ffmpeg-devel [mailto:ffmpeg-devel-bounces at ffmpeg.org] On
>> Behalf
>>>> Of Moritz Barsnick
>>>> Sent: Thursday, November 30, 2017 10:33 PM
>>>> To: FFmpeg development discussions and patches
>>>> <ffmpeg-devel at ffmpeg.org>
>>>> Subject: Re: [FFmpeg-devel] [PATCH 1/2] vaapi_h264: Add named options
>>>> for setting profile and level
>>>>
>>>> On Thu, Nov 30, 2017 at 08:52:21 +0000, Li, Zhong wrote:
>>>>>> +    { LEVEL("6",   60) },
>>>>>> +    { LEVEL("6.1", 61) },
>>>>>> +    { LEVEL("6.2", 62) },
>>>>>
>>>>> IIRC, level 5.2 is the maximum level of H264?
>>>>
>>>> Higher levels were introduced in 2016. Edition V12 of H.264 lists 6,
>>>> 6.1 and 6.2 in Annex A, Table A-1. It basically lists the same thing
>>>> as
>>>> Wikipedia:
>>>> https://en.wikipedia.org/wiki/H.264/MPEG-4_AVC#Levels
>>>
>>> Exactly.
>> To clarify, are you happy with this patch and the matching one for H.265
>> now?
> 
> Yeah, LGTM. 
> For h265, level_idc is not set by avctx->level in libx265, so we can just make it consistent with nvenc instead of libx264. 

Yep.

Applied; thank you!

- Mark


More information about the ffmpeg-devel mailing list