[FFmpeg-devel] [PATCH] lavf/mov: atom box parsing return eof cause play fail

[Michael Niedermayer]

On Tue, Dec 05, 2017 at 11:34:12AM +0800, tiejun.peng wrote:
> 1.add warning info about corrupted atom box parsing.
> 2.atom box parsing return eof cause mov_read_close called in mov_read_header
> and user have no chance to play the file.

i think someone should cleanup the english, it sounds a bit odd


[...]
> @@ -6609,7 +6632,8 @@ static int mov_read_header(AVFormatContext *s)
>      do {
>      if (mov->moov_retry)
>          avio_seek(pb, 0, SEEK_SET);
> -    if ((err = mov_read_default(mov, pb, atom)) < 0) {
> +    /* EOF don't mean the file to play fail*/

> +    if ((err = mov_read_default(mov, pb, atom) && err != AVERROR_EOF) < 0) {

this does look wrong

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Those who are too smart to engage in politics are punished by being
governed by those who are dumber. -- Plato 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20171206/411e1118/attachment.sig>