[FFmpeg-devel] [PATCH 1/3] lavf/matroskadec: resync if cluster parsing fails while seeking

Carl Eugen Hoyos ceffmpeg at gmail.com
Sun Dec 10 16:03:16 EET 2017


2017-12-09 3:24 GMT+01:00 Rodger Combs <rodger.combs at gmail.com>:

> -            if (matroska_parse_cluster(matroska) < 0)
> -                break;
> +            if ((ret = matroska_parse_cluster(matroska)) < 0) {
> +                if ((ret == AVERROR_EOF) || matroska_resync(matroska, pos) < 0)

If you believe the brackets improve readability, please keep them!

If you agree with me that they make reading the code more
difficult if anything, please remove them.

Carl Eugen


More information about the ffmpeg-devel mailing list