[FFmpeg-devel] [FFmpeg-cvslog] avfilter/vf_overlay: add premultiplied alpha mode

[Michael Niedermayer]

On Sat, Dec 16, 2017 at 05:44:03PM +0000, Paul B Mahol wrote:
> ffmpeg | branch: master | Paul B Mahol <onemda at gmail.com> | Tue Aug  1 12:34:44 2017 +0200| [d29f784a54f2c91a0cdd3a2cc3bb000a99244f49] | committer: Paul B Mahol
> 
> avfilter/vf_overlay: add premultiplied alpha mode
> 
> Signed-off-by: Paul B Mahol <onemda at gmail.com>
> 
> > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=d29f784a54f2c91a0cdd3a2cc3bb000a99244f49
> ---

This breaks fate here (gcc (Ubuntu 4.8.5-2ubuntu1~14.04.1) 4.8.5 x86-64)

--- ./tests/ref/fate/filter-overlay_rgb_rgba	2017-12-15 20:24:03.586225583 +0100
+++ tests/data/fate/filter-overlay_rgb_rgba	2017-12-18 00:23:08.601649951 +0100
@@ -3,4 +3,4 @@
 #codec_id 0: rawvideo
 #dimensions 0: 128x128
 #sar 0: 1/1
-0,          0,          0,        1,    49152, 0xb0e3d586
+0,          0,          0,        1,    49152, 0xcd3d78ab
Test filter-overlay_rgb_rgba failed. Look at tests/data/fate/filter-overlay_rgb_rgba.err for details.
make: *** [fate-filter-overlay_rgb_rgba] Error 1
make: *** Waiting for unfinished jobs....
--- ./tests/ref/fate/filter-overlay_rgba_rgba	2017-12-15 20:24:03.586225583 +0100
+++ tests/data/fate/filter-overlay_rgba_rgba	2017-12-18 00:23:08.669649953 +0100
@@ -3,4 +3,4 @@
 #codec_id 0: rawvideo
 #dimensions 0: 128x128
 #sar 0: 1/1
-0,          0,          0,        1,    65536, 0x33549946
+0,          0,          0,        1,    65536, 0x37743c6b
Test filter-overlay_rgba_rgba failed. Look at tests/data/fate/filter-overlay_rgba_rgba.err for details.
make: *** [fate-filter-overlay_rgba_rgba] Error 1

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If a bugfix only changes things apparently unrelated to the bug with no
further explanation, that is a good sign that the bugfix is wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20171218/0471eaee/attachment.sig>