[FFmpeg-devel] [PATCH] lavc/vaapi_encode: give a debug message if attrs unsupported.

[Mark Thompson]

On 19/12/17 06:25, Jun Zhao wrote:
> From 8400fa85b7af47c3cff6abd87fdc392ac7891e35 Mon Sep 17 00:00:00 2001
> From: Jun Zhao <jun.zhao at intel.com>
> Date: Tue, 19 Dec 2017 14:13:58 +0800
> Subject: [PATCH] lavc/vaapi_encode: give a debug message if attrs unsupported.
> 
> Give a debug message when query attribute get VA_ATTRIB_NOT_SUPPORTED,
> it's will help to trace and debug some issue.
> 
> Signed-off-by: Jun Zhao <jun.zhao at intel.com>
> ---
>  libavcodec/vaapi_encode.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/libavcodec/vaapi_encode.c b/libavcodec/vaapi_encode.c
> index 1d3cb4db83..9bc9c89d3b 100644
> --- a/libavcodec/vaapi_encode.c
> +++ b/libavcodec/vaapi_encode.c
> @@ -1048,6 +1048,8 @@ static av_cold int vaapi_encode_config_attributes(AVCodecContext *avctx)
>              // Unfortunately we have to treat this as "don't know" and hope
>              // for the best, because the Intel MJPEG encoder returns this
>              // for all the interesting attributes.
> +            av_log(avctx, AV_LOG_DEBUG, "Attribute (%d) is not supported.\n",
> +                   attr[i].type);
>              continue;
>          }
>          switch (attr[i].type) {
> -- 
> 2.14.1
> 

LGTM, applied.

On 19/12/17 07:02, Jun Zhao wrote:
> On 2017/12/19 14:29, 刘歧 wrote:
>>> On 19 Dec 2017, at 14:25, Jun Zhao <mypopydev at gmail.com> wrote:
>>>
>>> <0001-lavc-vaapi_encode-give-a-debug-message-if-attrs-unsu.patch>
>> I saw you using AV_LOG_DEBUG, What about use AV_LOG_WARNING? Because that message is tell user attrs unsupported.
>>
>> Thanks
> 
> I don't ensure user like the message as "Attribute 35 is not supported"
> this style. And I guess Mark just want to become silent in this case in
> original code.

See the comment above the message.  We get:

[mjpeg_vaapi @ 0x5654cf1bb520] Attribute (5) is not supported.
[mjpeg_vaapi @ 0x5654cf1bb520] Attribute (13) is not supported.

helpfully telling us that rate control isn't available for JPEG.  (A driver could in theory implement something other than CQP, but I don't think there is much reason to.)

Thanks,

- Mark