[FFmpeg-devel] [PATCHv2] configure: fix pkg-config check for libtls

Hendrik Leppkes h.leppkes at gmail.com
Wed Dec 20 01:41:25 EET 2017


On Wed, Dec 20, 2017 at 12:32 AM, Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:
> 2017-12-19 18:28 GMT+01:00 James Almer <jamrial at gmail.com>:
>> On 12/19/2017 2:13 PM, Stefan _ wrote:
>>> Last patch had a minor issue, fixed version attached.
>>
>> Applied.
>>
>> The fallback check for that matter should be removed. It's pointless
>> since every supported version of the library ships a .pc file
>
> Which is completely unrelated to the fact that less common
> toolchains do not provide pkg-config.

We should not have to maintain the dependency lists of external
libraries (which can even change when the library changes without us
knowing when the API remains the same), especially when a standard
tool exists to handle this for us. pkg-config was specifically
designed for this.
Changes are that such fallback cases are notoriously broken due to any
mainstream system not ever reaching them, so its best to encourage
everyone to use the mainstream option as well.

>
> It is sadly impossible now to test on aix, I still believe it
> would make sense to support as many systems as possible.
>

There is pkg-config for AIX in third-party repos (which is probably
where you get most AIX stuff, since its otherwise a proprietary OS).

- Hendrik


More information about the ffmpeg-devel mailing list