[FFmpeg-devel] [PATCH 2/5] mpeg: add experimental support for PSMF audio.

[Michael Niedermayer]

On Tue, Dec 26, 2017 at 04:06:49PM +0800, misty at brew.sh wrote:
> From: Maxim Poliakovski <maximumspatium at googlemail.com>
> 
> Changes by Misty De Meo <mistydemeo at gmail.com>:
> 
> atrac3plus_parser: remove return statements for invalid data
> 
> atrac3plus_parser: use libavcodec's oma
> 
> Signed-off-by: Misty De Meo <mistydemeo at gmail.com>
> ---
>  libavcodec/Makefile            |   1 +
>  libavcodec/allcodecs.c         |   1 +
>  libavcodec/atrac3plus_parser.c | 150 +++++++++++++++++++++++++++++++++++++++++
>  libavformat/mpeg.c             |  27 +++++++-
>  4 files changed, 178 insertions(+), 1 deletion(-)
>  create mode 100644 libavcodec/atrac3plus_parser.c

This breaks playback of atrac3p (atrac3p\ phase\ inv\ 2.at3)

Ive not investigated, but i doubt very much that simply removing the
error returns will work. Every single error path must be handled
appropriately and you should ensure that its all correct.
Not loosing or corrupting data on any error path and not doing
anything else bad or undefined ...

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Why not whip the teacher when the pupil misbehaves? -- Diogenes of Sinope
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20171227/aed59ba4/attachment.sig>