[FFmpeg-devel] [PATCH] lavr: deprecate the entire library

[Derek Buitenhuis]

On 12/25/2017 5:53 PM, Rostislav Pehlivanov wrote:
> Deprecate the entire library. Merged years ago to provide compatibility
> with Libav, it remained unmaintained by the FFmpeg project and duplicated
> functionality provided by libswresample.
> 
> In order to improve consistency and reduce attack surface, as well as to ease
> burden on maintainers, it has been deprecated. Users of this library are asked
> to migrate to libswresample, which, as well as providing more functionality,
> is faster and has higher accuracy.
> 
> Signed-off-by: Rostislav Pehlivanov <atomnuker at gmail.com>
> ---
>  configure                  |  4 ++--
>  doc/APIchanges             | 10 ++++++++++
>  libavresample/avresample.h | 30 +++++++++++++++++++++++++-----
>  3 files changed, 37 insertions(+), 7 deletions(-)

[...]

> +2017-xx-xx - xxxxxxx - lavr 4.0.0 - avresample.h
> +  Deprecate the entire library. Merged years ago to provide compatibility
> +  with Libav, it remained unmaintained by the FFmpeg project and duplicated
> +  functionality provided by libswresample.
> +
> +  In order to improve consistency and reduce attack surface, as well as to ease
> +  burden on maintainers, it has been deprecated. Users of this library are asked
> +  to migrate to libswresample, which, as well as providing more functionality,
> +  is faster and has higher accuracy.

Maybe drop 'burden on maintainers', since it says directly above that it is
unmaintained, which is a direct contradiction.

> diff --git a/libavresample/avresample.h b/libavresample/avresample.h
> index 193443e2a6..57889c572c 100644
> --- a/libavresample/avresample.h
> +++ b/libavresample/avresample.h
> @@ -103,10 +103,10 @@

Doxygen should be updated with the @deprecated tag, and a pointer to swresample
on everything.

Other than that, I think it is OK to go ahead and push this soon. Thanks for
giving it a bit of time post-Christmas.

- Derek