[FFmpeg-devel] [PATCH 1/3] libavcodec/cinepakenc.c: comments cleanup (contents)

[u-9iep at aetey.se]

Hello Michael,

On Tue, Feb 07, 2017 at 03:09:56AM +0100, Michael Niedermayer wrote:
> > What about the other patches from that series?
> 
> > The second one is purely cosmetic (looks useful to me but not much
> > of concern)
> 
> I have no oppinion about // vs /**/ comments but in the absence of
> a reason to change them my gut feeling leans toward leaving things
> as they are for "git blame" simplification.

No objection.

> > while the third (tiny) one is about correcting an inverted
> > explanation in a comment.
> 
> I think the 3rd depends on the 2nd

No, the third is standalone.

It was possibly wrong to put them in the same series, but otherwise a
confusion would be probably easy, too.

> another point which was brought up by jb on IRC and in RL longer ago
> was that ideally the author field in git should contain a name.

> It may help with contacting one in the far future or with simply
> refering to the author as in

> who wrote the cinepack optimizations?
> Author: addr-see-the-website at aetey.se <addr-see-the-website at aetey.se>

Contact data is not identity even though this fact is ignored in some
widely spread (misled) practices, which the above example illustrates
well. There are actually two separate questions:

Q: Who wrote the cinepak optimizations?
A: A person known as Rl @ Aetey Global Technologies AB.

Q: How to contact him/her?
A: The author does not wish to publicize any contact handle which
   is open to abuse, like a permanent mail address. YMMV.

> is a bit cumbersome but its not mine to judge that. If you want
> that in the author field, thats ok as far as iam concerned, i just
> have difficulty imagening that being intended over a pronouncable
> name (even if thats a pseudonym) before <addr-see-the-website at aetey.se>

The data in the address field is not the/a pseudonym but a hint to a
possibly existing way to contact the author (no guarantee).

If you or any of the developers here wish to have a long term contact
handle to me, I will gladly provide it. But it will be invalidated as
soon as it becomes published or leaked.

Does this look reasonable to you?

Regards,
Rune