[FFmpeg-devel] [PATCH] Cinepak: speed up decoding several-fold, depending on the scenario, by supporting multiple output pixel formats.

[wm4]

On Tue, 7 Feb 2017 15:57:03 +0100
u-9iep at aetey.se wrote:

> On Mon, Feb 06, 2017 at 11:05:06PM +0100, Clément Bœsch wrote:
> > On Mon, Feb 06, 2017 at 10:05:10AM +0100, u-9iep at aetey.se wrote:
> > [...]  
> > > > No, code quality is not outside the scope of your patch.  
> > > 
> > > Code quality is a subjective matter.
> > >   
> > 
> > I'm not going to fight with you  
> 
> Appreciated.
> 
> > several developers consider your patch
> > does not pass the quality requirements of the project. It's arbitrary,
> > [... skipped ...], but that's the current policy of the project.  
> 
> Well said.
> 
> > Changing that policy is outside the scope of this patch.  
> 
> :)
> 
> > [...]  
> > > > The use of the environment variable is not tolerable, this is a blocker.  
> > > 
> > > It is explicitly specified that it is _not_ being used,  
> > 
> > Then please drop the dead code.  
> 
> Ok, why not.
> 
> Still, given the disapproval of the "code quality" without a tangible
> criteria to follow, I can hardly take any accomodating steps, barring
> the omission of the unused code - would this step be enough?

Bad:
- dead code
- code duplication
- not using standard API mechanisms (get_format)
- using unusual mechanisms that are normally not used in FFmpeg
  libraries or libraries in general (configuration via getenv)

It's not so complicated if you make an effort to try to understand.