[FFmpeg-devel] [PATCH] nvenc: FIX wrong forced keyframe behavior

Miroslav Slugeň thunder.m at email.cz
Sun Feb 12 21:56:44 EET 2017


Dne 12.2.2017 v 20:52 Timo Rothenpieler napsal(a):
> On 2/12/2017 8:43 PM, Miroslav Slugeň wrote:
>> Dne 12.2.2017 v 20:29 Timo Rothenpieler napsal(a):
>>> The current behavior is intended like it is.
>>> On the default of -1, it does not care about I/IDR frame requests, in
>>> mode 0 it will generate intra frames, and in mode 1 it will generate
>>> full IDR frames.
>>> _______________________________________________
>>> ffmpeg-devel mailing list
>>> ffmpeg-devel at ffmpeg.org
>>> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>> This is not clever, because i checked both libx264 and libx265 and both
>> of them has same behavior like i proposed in patch.
>>
>> Also explanation of this function is than wrong:
>> { "forced-idr",   "If forcing keyframes, force them as IDR frames."}
>>
>> There is nothing about disabled forcing keyframes at all.
>>
>> So we have two options:
>> 1. We should change it in NVENC
>> or
>> 2. We should change it in libx264 and libx265
> Changing it in nvenc now would be kind of an API break, as the behaviour
> might change without someone expecting it.
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
I don't think so, onlything is changed is when you forcing keyframes 
with -forced_keyframes option it was not working in NVENC without 
specifiing -force_idr 0 or 1, is there any other situation when some 
parts of ffmpeg will force key frames and NVENC naturaly ignore them?

M.


More information about the ffmpeg-devel mailing list