[FFmpeg-devel] [PATCH 2/2] avformat/matroskaenc: Regression fix for invalid MKV headers

Soft Works softworkz at hotmail.com
Fri Jan 6 22:39:12 EET 2017


> James Almer wrote
> 
> 
> start_ebml_master_crc32() only reserves the space needed for the CRC32 element,
> which is then written by end_ebml_master_crc32(). The preliminary header will
> have a couple six bytes long Void elements that every parser will promptly
> ignore.
> 
> CRC32 elements on this preliminarily state are pointless. Extra cycles wasted
> calculating something that will be overwritten and recalculated at the end of
> the process.

Thank you very much for the clarification. I made the change and checked the resulting
headers. I'll submit it once fate is done.

Now I hope someone will review the avio change.

Thanks again,

softworkz


More information about the ffmpeg-devel mailing list