[FFmpeg-devel] [PATCH] Newtek SpeedHQ decoder.

[Carl Eugen Hoyos]

2017-01-08 13:55 GMT+01:00 Steinar H. Gunderson <steinar+ffmpeg at gunderson.no>:
> On Sun, Jan 08, 2017 at 01:45:07PM +0100, Paul B Mahol wrote:
>>> diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
>>> index ca8b786077..23e1ecc7a7 100644
>>> --- a/libavcodec/avcodec.h
>>> +++ b/libavcodec/avcodec.h
>>> @@ -388,6 +388,14 @@ enum AVCodecID {
>>>      AV_CODEC_ID_DXV,
>>>      AV_CODEC_ID_SCREENPRESSO,
>>>      AV_CODEC_ID_RSCC,
>>> +    AV_CODEC_ID_SHQ0,
>>> +    AV_CODEC_ID_SHQ1,
>>> +    AV_CODEC_ID_SHQ2,
>>> +    AV_CODEC_ID_SHQ3,
>>> +    AV_CODEC_ID_SHQ4,
>>> +    AV_CODEC_ID_SHQ5,
>>> +    AV_CODEC_ID_SHQ7,
>>> +    AV_CODEC_ID_SHQ9,
>> Wrong place, put it after YLC, bellow.
>
> Will move. What's the intended ordering here, really?

Important thing is not to change ids of
existing codecs.

>>> --- a/libavcodec/bitstream.c
>>> +++ b/libavcodec/bitstream.c
>>> @@ -126,14 +126,6 @@ static int alloc_table(VLC *vlc, int size, int
>>> use_static)
>>>      return index;
>>>  }
>>>
>>> -static av_always_inline uint32_t bitswap_32(uint32_t x)
>>> -{
>>> -    return (uint32_t)ff_reverse[ x        & 0xFF] << 24 |
>>> -           (uint32_t)ff_reverse[(x >> 8)  & 0xFF] << 16 |
>>> -           (uint32_t)ff_reverse[(x >> 16) & 0xFF] << 8  |
>>> -           (uint32_t)ff_reverse[ x >> 24];
>>> -}
>>> -
>> Huh?!? This move should be separate commit.
>
> It's not a removal; it's a move.

And this move has to be a separate commit.

Since you are moving it to a public header, it would
have to prefixed with av_
(Not sure if duplicating would be preferable.)

Carl Eugen