[FFmpeg-devel] [PATCH v3 2/2] Newtek SpeedHQ decoder.

Michael Niedermayer michael at niedermayer.cc
Mon Jan 9 22:44:42 EET 2017


On Mon, Jan 09, 2017 at 08:21:25PM +0100, Steinar H. Gunderson wrote:
> On Mon, Jan 09, 2017 at 08:17:18PM +0100, Michael Niedermayer wrote:
> >> +        /* Reverse the AC VLC, because INIT_VLC_LE wants it in that order. */
> >> +        for (i = 0; i < FF_ARRAY_ELEMS(speedhq_vlc); ++i) {
> >> +            speedhq_vlc[i][0] = reverse(speedhq_vlc[i][0], speedhq_vlc[i][1]);
> >> +        }
> > This makes the init thread unsafe
> > it would be better if the table was const and this wasnt done at
> > runtime
> 
> Do you want all three tables, or just this one?
> 
> Optionally, I can keep the original one const, and just copy into a temporary
> here.

anything that works and is thread safe is fine with me
pick what you prefer from what people like


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

What does censorship reveal? It reveals fear. -- Julian Assange
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170109/4ebba23e/attachment.sig>


More information about the ffmpeg-devel mailing list