[FFmpeg-devel] [PATCH] avformat: Add rtp_mpegtsraw (MPEG-TS RAW Stream output)

[Moritz Barsnick]

On Fri, Jan 13, 2017 at 07:57:28 -0500, Andreas Håkon wrote:
> +static int rtp_mpegtsraw_write_close(AVFormatContext *s)
> +{

ffmpeg bracket style is different.
https://ffmpeg.org/developer.html#toc-Code-formatting-conventions
(indent's "-kr" implies "-br", which means that the opening curly
bracket is on the same line.)

> +    struct MuxChain *chain = s->priv_data;
> +	int ret = AVERROR(ENOMEM);
> +	ret = rtp_mpegts_write_header(s);

Why would you assign a value to ret which you immediately discard?

> +        avformat_free_context(chain->mpegts_ctx);
> +
> +		chain->mpegts_ctx = NULL;

Indentation is inconsistent, throughout the patch BTW.

> +    int ret = 0;
> +
> +    ret = av_write_frame(chain->rtp_ctx, pkt);

Same here with the assignment.

Moritz