[FFmpeg-devel] patch 1: comments cleanup in libavcodec/cinepakenc.c

u-9iep at aetey.se u-9iep at aetey.se
Sat Jan 28 12:42:24 EET 2017


Comments cleanup:
 - change the encoding of the original developer name from ISO-8859-1 to UTF-8
 - remove the stale/completed TODO list
 - fix a typo

No code changes, only improved consistency in the comments.

I kindly ask to apply this cleanup, which of course was due from the beginning.

Attaching the patch.

Regards,
Rune
-------------- next part --------------
--- libavcodec/cinepakenc.c.orig	2016-12-05 23:07:54.000000000 +0100
+++ libavcodec/cinepakenc.c	2017-01-28 10:10:47.078999401 +0100
@@ -1,5 +1,5 @@
 /*
- * Cinepak encoder (c) 2011 Tomas Härdin
+ * Cinepak encoder (c) 2011 Tomas Härdin
  * http://titan.codemill.se/~tomhar/cinepakenc.patch
  *
  * Fixes and improvements, vintage decoders compatibility
@@ -23,9 +23,6 @@
 ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
 OTHER DEALINGS IN THE SOFTWARE.
 
- * TODO:
- * - optimize: color space conversion, ...
- * - implement options to set the min/max number of strips?
  * MAYBE:
  * - "optimally" split the frame into several non-regular areas
  *   using a separate codebook pair for each area and approximating
@@ -92,7 +89,7 @@
 #define MAX_STRIPS  32      //Note: having fewer choices regarding the number of strips speeds up encoding (obviously)
 #define MIN_STRIPS  1       //Note: having more strips speeds up encoding the frame (this is less obvious)
 // MAX_STRIPS limits the maximum quality you can reach
-//            when you want hight quality on high resolutions,
+//            when you want high quality on high resolutions,
 // MIN_STRIPS limits the minimum efficiently encodable bit rate
 //            on low resolutions
 // the numbers are only used for brute force optimization for the first frame,


More information about the ffmpeg-devel mailing list