[FFmpeg-devel] patch 2: comments style cleanup in libavcodec/cinepakenc.c

u-9iep at aetey.se u-9iep at aetey.se
Sat Jan 28 13:47:20 EET 2017


On Sat, Jan 28, 2017 at 12:31:33PM +0100, wm4 wrote:
> On Sat, 28 Jan 2017 11:50:27 +0100
> u-9iep at aetey.se wrote:
> 
> > Comments style cleanup:
> >  - make all comments follow the same style (C-style)
> > 
> > No code changes, only improved consistency and clarity in the comments.
> > No changes in the comments besides whitespace and the syntactic delimiters.
> > 
> > The original file uses a mixture of C and C++ style comments, not for
> > clarity but for historical reasons (among others commenting in a hurry).
> > 
> > With the change applied the structure of the file is more consequent
> > and also makes easier a possible code reuse with different C compilers.
> > 
> > Attaching the patch.
> > 
> > Regards,
> > Rune
> 
> "//" comments are ok in the ffmpeg codebase, because it's C99.

Yes I knew this. The change is purely cosmetic and not overly important
but in my humble opinion useful.

A consequent style makes it easier to read and understand the code.

Regards,
Rune



More information about the ffmpeg-devel mailing list