[FFmpeg-devel] [PATCH] pthread_frame: save the FF_DEBUG_THREADS option in FrameThreadContext.

Michael Niedermayer michael at niedermayer.cc
Sun Jul 9 01:49:18 EEST 2017

On Sat, Jul 08, 2017 at 03:38:11PM -0700, Wan-Teh Chang wrote:
> Hi Ronald,
> On Sat, Jul 8, 2017 at 2:33 PM, Ronald S. Bultje <rsbultje at gmail.com> wrote:
> >
> > I can see the design from the patch.
> >
> > What's missing is a justification for the downside of the design, which is
> > that updates to this variable by the user are no longer propagated to the
> > worker threads.
> My justification is the YAGNI principle.
> Although the current code allows the FF_DEBUG_THREADS option to be
> toggled dynamically, I believe that was not intended, and I believe
> nobody actually does that. In my (admittedly limited) code search, I
> only see the FF_DEBUG_THREADS option set via the -debug thread_ops
> command-line option.

ffmpeg (the command line tool) allows changing the AVCodecContext->debug
value at runtime


Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No great genius has ever existed without some touch of madness. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170709/f806a77c/attachment.sig>

More information about the ffmpeg-devel mailing list