[FFmpeg-devel] Fwd: [PATCH] avutil/frame: document data alignment restriction

Nicolas George george at nsup.org
Sat Jul 22 17:53:45 EEST 2017

Le quartidi 4 thermidor, an CCXXV, Muhammad Faiz a écrit :
> It fixed the testcase's crash, but didn't fix the bug.

So it is not FIXED.

> It is easy for application:
>    - always use av_frame_get_buffer
>    - never modify audio data pointer.

Even easier: never use libavcodec. Kind of defeating the purpose. The
point of a library is to reduce the amount of code required by
applications. By adding that constraint, you either restrict what the
applications can do with the library or require more code from them.
Both are bad, both should be avoided if possible. And in this particular
case it is possible.

> On the contrary, handling unaligned data/linesize in the library is not easy.

It is very easy, I have already implemented it. The patch is on the
mailing-list since two months ago.


  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170722/acf1cdee/attachment.sig>

More information about the ffmpeg-devel mailing list