[FFmpeg-devel] [PATCH 1/2] avcodec/dcaadpcm: check for av_malloc() failure

[James Almer]

On 7/22/2017 2:50 PM, foo86 wrote:
> Fixes CID 1409915.
> ---
>  libavcodec/dcaadpcm.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/libavcodec/dcaadpcm.c b/libavcodec/dcaadpcm.c
> index 8742c7ccf6..e00f81f011 100644
> --- a/libavcodec/dcaadpcm.c
> +++ b/libavcodec/dcaadpcm.c
> @@ -215,6 +215,9 @@ av_cold int ff_dcaadpcm_init(DCAADPCMEncContext *s)
>          return -1;
>  
>      s->private_data = av_malloc(sizeof(premultiplied_coeffs) * DCA_ADPCM_VQCODEBOOK_SZ);
> +    if (!s->private_data)
> +        return -1;

AVERROR(ENOMEM)

You could while at it change the call to ff_dcaadpcm_init() in dcaenc.c
to actually look and propagate this value.

> +
>      precalc(s->private_data);
>      return 0;
>  }
>