[FFmpeg-devel] [PATCH 1/2] fate: add fate-sws-pixdesc-query

[Clément Bœsch]

On Mon, Jul 24, 2017 at 08:02:25PM +0200, Carl Eugen Hoyos wrote:
> 2017-07-24 17:03 GMT+02:00 Clément Bœsch <u at pkh.me>:
> > On Mon, Jul 24, 2017 at 01:55:40AM +0200, Carl Eugen Hoyos wrote:
> >> 2017-03-19 15:00 GMT+01:00 Clément Bœsch <u at pkh.me>:
> >> > Test the pixel format querying within libswscale.
> >>
> >> Afaict, this broke fate on big-endian:
> >> $ make fate-sws-pixdesc-query
> >> TEST    sws-pixdesc-query
> >> --- ./tests/ref/fate/sws-pixdesc-query  2017-07-23 16:42:59.000000000 -0700
> >> +++ tests/data/fate/sws-pixdesc-query   2017-07-23 16:50:48.000000000 -0700
> >> @@ -407,8 +407,8 @@
> >>     rgb8
> >>     rgb4
> >>     rgb4_byte
> >> -   abgr
> >> -   bgra
> >> +   argb
> >> +   rgba
> >>     rgb48be
> >>     rgb48le
> >>     rgb565be
> >> @@ -427,8 +427,8 @@
> >>     bgr8
> >>     bgr4
> >>     bgr4_byte
> >> -   argb
> >> -   rgba
> >> +   abgr
> >> +   bgra
> >>     bgr565be
> >>     bgr565le
> >>     bgr555be
> >> Test sws-pixdesc-query failed. Look at
> >> tests/data/fate/sws-pixdesc-query.err for details.
> >> make: *** [fate-sws-pixdesc-query] Error 1
> >>
> >
> > can you try https://github.com/ubitux/FFmpeg/tree/sws-query ?
> 
> It works, thank you!
> 
> I just sent an alternative approach, I believe it is less convoluted
> and simplifies the existing code but has the disadvantage that I
> also have to fix five asm functions.
> 
> Do you prefer your approach?
> 

I won't comment on the swscale part, I leave that to the sws maintainer.
No opinion in particular.

That patchset can still be applied, at least the first 2 patches, as
convenience (sorted pix fmt, more predictable output).

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170724/b31e7b08/attachment.sig>