[FFmpeg-devel] [Patch] nvenc : Add P016 support

[Philip Langdale]

On 2017-07-25 12:20, Yogender Gupta wrote:
> Can someone else push these patches to GIT.
> 
> Regards,
> Yogender
> 
> -----Original Message-----
> From: ffmpeg-devel [mailto:ffmpeg-devel-bounces at ffmpeg.org] On Behalf
> Of Timo Rothenpieler
> Sent: Tuesday, July 18, 2017 5:16 PM
> To: ffmpeg-devel at ffmpeg.org
> Subject: Re: [FFmpeg-devel] [Patch] nvenc : Add P016 support
> 
> Am 18.07.2017 um 13:24 schrieb Yogender Gupta:
>> Add P016 support to NVENC.
>> 
>> Thanks,
>> Yogender
> 
> All three patches look fine to me in general.
> I vaguely remember there being some reason for P016 being missing so
> far, but it might be long fixed.
> 
> I'm not at home and can't really push patches from here.
> If someone(philipl?) remembers if there was any particular issue, or
> if it's fine by now, it's a LGTM from me!
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> -----------------------------------------------------------------------------------
> This email message is for the sole use of the intended recipient(s)
> and may contain
> confidential information.  Any unauthorized review, use, disclosure or
> distribution
> is prohibited.  If you are not the intended recipient, please contact
> the sender by
> reply email and destroy all copies of the original message.
> -----------------------------------------------------------------------------------
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

I can push, but to answer Timo's question: I did not add P016 to nvenc 
because it is
technically not correct to pass 12bit content through a 10bit surface - 
that will lead
to truncation, rather than dithering. If you are telling us that nvenc 
supports 12bit
input and will correctly dither, then great. Otherwise, it's more 
correct to not
support and force dithering to happen through swscale. You could also 
write cuda
accelerated dithering.

--phil