[FFmpeg-devel] [PATCH] avcodec/aac: add 960/120 MDCT window

[Hendrik Leppkes]

2017-07-25 9:46 GMT+02:00 Paul B Mahol <onemda at gmail.com>:
> On 7/16/17, Paul B Mahol <onemda at gmail.com> wrote:
>> Signed-off-by: Rostislav Pehlivanov <atomnuker at gmail.com>
>> Signed-off-by: Alex Converse <alex.converse at gmail.com>
>> Signed-off-by: Paul B Mahol <onemda at gmail.com>
>> ---
>>  Changelog                     |   1 +
>>  libavcodec/aac.h              |   3 +
>>  libavcodec/aacdec_template.c  | 126
>> +++++++++++++++++++++++++++++++++++++++---
>>  libavcodec/aacsbr_template.c  |   3 +-
>>  libavcodec/aactab.c           | 122
>> ++++++++++++++++++++++++++++++++++++++++
>>  libavcodec/aactab.h           |   8 +++
>>  libavcodec/sinewin.h          |   4 +-
>>  libavcodec/sinewin_tablegen.h |   5 +-
>>  8 files changed, 259 insertions(+), 13 deletions(-)
>>
>
> ping

Can you document the limitations that 960 support still has? IIRC it
doesn't work with SBR yet? Anything else?
Is it supported both in float and fixed mode?

Not saying any of this needs to be fixed, just having the "state"
clearly documented in the commit would be nice for future
improvements. :)

- Hendrik