[FFmpeg-devel] [PATCH] FATE: Add test for libavfilter/scale2ref

Michael Niedermayer michael at niedermayer.cc
Mon Jun 5 03:07:58 EEST 2017


On Sun, Jun 04, 2017 at 03:53:31AM -0400, Kevin Mark wrote:
> This new FATE test for the scale2ref filter makes use of the recently
> added scale2ref-specific variables to maintain the aspect ratio of a
> test input.
> 
> Filtergraph explanation:
> [main] has an AR of 4:3. [ref] has an AR of 16:9.
> 640 / 4 = 160. So the new width for [main] is 160.
> 160 / ((320 / 240) * (1 / 1)) = 160 / (4 / 3) = 120. So the new
> height for [main] is 120.
> 160 / 120 = 4 / 3 so [main]'s aspect ratio has been maintained while
> using [ref]'s width as a reference point.
> 
> [ref] is nullsink'd since it is left unchanged by scale2ref (and so
> shouldn't need to be tested).
> 
> If we were to use "iw/4:-1" in place of "iw/4:ow/mdar":
> 640 / 4 = 160. So the new width for [main] would be 160.
> 360 / 4 = 90. So the new height for [main] would be 90.
> 160 / 90 = 16 / 9 so [main] now has the same aspect ratio as [ref]
> which is probably what you do not want.
> 
> This is currently the only test for scale2ref.
> 
> Signed-off-by: Kevin Mark <kmark937 at gmail.com>
> ---
>  tests/fate/filter-video.mak                 |  4 ++++
>  tests/filtergraphs/scale2ref_keep_aspect    |  5 +++++
>  tests/ref/fate/filter-scale2ref_keep_aspect | 14 ++++++++++++++
>  3 files changed, 23 insertions(+)
>  create mode 100644 tests/filtergraphs/scale2ref_keep_aspect
>  create mode 100644 tests/ref/fate/filter-scale2ref_keep_aspect

applied

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The greatest way to live with honor in this world is to be what we pretend
to be. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170605/f22544a8/attachment.sig>


More information about the ffmpeg-devel mailing list