[FFmpeg-devel] [PATCH] fate: add fate-adts-id3v1-demux
h.leppkes at gmail.com
Mon Jun 5 17:33:37 EEST 2017
On Mon, Jun 5, 2017 at 4:29 PM, James Almer <jamrial at gmail.com> wrote:
> On 6/4/2017 8:49 PM, Michael Niedermayer wrote:
>> On Sun, Jun 04, 2017 at 01:08:39PM -0300, James Almer wrote:
>>> This test the demuxer discarding non ADTS frames at the beginning and
>>> end of the input.
>>> As a side effect, this commit also enables fate-adts-demux, which was
>>> accidentally disabled in 324f0fbff1245f9e9e1dda29ecb03138a2de287d.
>>> Signed-off-by: James Almer <jamrial at gmail.com>
>>> Sample is in http://0x0.st/6gI.aac
>> uploaded, we can change it though if a smaller file is wanted before
>> the test is pushed
> Well, i want it mainly because framecrc is much more informative and
> clearly reflects what this patch fixed, unlike crc.
> Since the sample i posted above is 130 frames long it would make a huge
> framecrc ref file, so my question was if a small sample that probes with
> a score of 1 is a good idea for the test or too fragile.
If its not really a probe test, you could just set a fixed format and
avoid any issues from that entirely.
More information about the ffmpeg-devel