[FFmpeg-devel] [PATCH] avcodec/fft_template: Fix multiple runtime error: signed integer overflow: -1943918714 - 1935113003 cannot be represented in type 'int'

[Michael Niedermayer]

On Thu, Jun 08, 2017 at 06:35:07PM -0400, Ronald S. Bultje wrote:
> Hi,
> 
> On Thu, Jun 8, 2017 at 6:10 PM, Michael Niedermayer <michael at niedermayer.cc>
> wrote:
> 
> > Signed value in
> > Unsigned
> > INTeger type
> 
> [..]
> > Both SUINT and unsigned should produce identical binaries
> 
> This seems to go against the rule that code should be as simple as possible.
> 
> Unsigned is simpler than SUINT if the outcome is the same.

You can simply add the part of my mail here as awnser that you snipped
away:

"But it makes the code hard to understand and maintain because these
 values are not positive integers but signed integers. Which for
 C standard compliance need to be stored in a unsigned type."

A type that avoids the undefinedness of signed but is semantically
signed is correct, unsigned is not.

If understandable code and maintainable code has no value to you,
you would favour using single letter variables exclusivly and would
never use typedef.
But you do not do that.

I fail to understand why you insist on using unsigned in place of a
more specific type, it is not the correct nor clean thing to do.


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The bravest are surely those who have the clearest vision
of what is before them, glory and danger alike, and yet
notwithstanding go out to meet it. -- Thucydides
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170609/93177a64/attachment.sig>