[FFmpeg-devel] [PATCH] fate: add test for -time_base option

James Almer jamrial at gmail.com
Sat Jun 10 18:19:39 EEST 2017


On 6/9/2017 7:10 PM, Michael Bradshaw wrote:
> Hi,
> 
> Attached patch adds a FATE test for the -time_base option, as
> promised[1] (months ago). This is my first FATE patch, so please be
> sure to check for stupid mistakes and whatnot. I'm happy to revise it
> as needed.
> 
> Thanks,
> 
> --Michael
> 
> [1]: http://ffmpeg.org/pipermail/ffmpeg-devel/2017-March/209432.html

Is mxf as output needed for this? If not, the framemd5() or framecrc()
fate functions (which use the muxers of the same name) would be a better
test. Those report the output timebase in a quick and easily readable way.

Using the md5() function lets you choose the output format then does an
md5 calculation of the entire output file, which in this case would
depend purely on the format of choice storing the time base somewhere in
the output for the md5 digest to be altered in case of failure (I assume
mxf does at least). And at an eventual failure one would have to look at
the output file to know exactly what failed, since a single md5 digest
isn't too informative.


More information about the ffmpeg-devel mailing list