[FFmpeg-devel] [RFC] Implement support for interplay MVE 0x06, 0x0F and 0x10

[Moritz Barsnick]

On Sat, Jun 17, 2017 at 19:13:52 +0200, Hein-Pieter van Braam wrote:
> +            s->pixel_ptr = frame->data[0] + x + y*frame->linesize[0];

Style: You might want to add spaces around '*'.

> +            if (! opcode) {

Style: You should drop the space.

> +            if (opcode < 0) {
> +                off_x = ((unsigned short)opcode - 0xC000) % frame->linesize[0];
> +                off_y = ((unsigned short)opcode - 0xC000) / frame->linesize[0];
> +                copy_from(s, s->last_frame, frame, off_x, off_y);
> +            }
> +            if (opcode > 0) {

else if?

> +                    if (opcode < 0) {
> +                        off_x = ((unsigned short)opcode - 0xC000) % s->cur_decode_frame->linesize[0];
> +                        off_y = ((unsigned short)opcode - 0xC000) / s->cur_decode_frame->linesize[0];
> +                        copy_from(s, s->prev_decode_frame, s->cur_decode_frame, off_x, off_y);
> +                    }
> +                    if (opcode > 0) {

Same here.

> +    if (s->frame_format == 0x06)
> +        ipvideo_decode_format_06_opcodes(s, frame);
> +
> +    if (s->frame_format == 0x10)
> +        ipvideo_decode_format_10_opcodes(s, frame);
> +
> +    if (s->frame_format == 0x11)
> +        ipvideo_decode_format_11_opcodes(s, frame);

Unless ipvideo_decode_format_NN_opcodes() modifies s->frame_format,
which doesn't seem to be the case, this is either if/else if/else if,
or switch/case.

Cheers,
Moritz