[FFmpeg-devel] [PATCH 1/4] avformat/aviobuf: fix flushing write buffers after seeking backward or forward

Michael Niedermayer michael at niedermayer.cc
Mon Jun 19 18:01:28 EEST 2017

On Mon, Jun 19, 2017 at 12:02:51AM +0200, Marton Balint wrote:
> This patch makes aviobuf work more like traditinal file IO, which is how people
> think about it.
> For example, in the past, aviobuf only flushed buffers until the current buffer
> position, even if more data was written to it previously, and a backward seek
> was used to reposition the IO context.
> From now, aviobuf will keep track of the written data, so no explicit seek will
> be required till the end of the buffer, or till the end of file before flushing.
> This fixes at least one regression, fate-vsynth3-flv was broken if
> flush_packets option was set to false, an explicit seek was removed in
> 4e3cc4bdd8acedbcc703607ed0efbb64bb5c3cc4.
> Also from now on, if a forward seek in the write buffer were to cause a gap
> between the already written data and the new file position, a flush will
> happen.
> The must_flush varable is also removed, which might have caused needless
> flushes with multiple seeks whithin the write buffer. Since we know the amount
> of data written to it, we will know when to flush.
> Signed-off-by: Marton Balint <cus at passwd.hu>
> ---
>  libavformat/avio.h    | 42 ++++++++++++++++++++++++++----------------
>  libavformat/aviobuf.c | 26 ++++++++++++++------------
>  libavformat/version.h |  2 +-
>  3 files changed, 41 insertions(+), 29 deletions(-)

Iam in favor of this patch


Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Those who would give up essential Liberty, to purchase a little
temporary Safety, deserve neither Liberty nor Safety -- Benjamin Franklin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170619/89734a70/attachment.sig>

More information about the ffmpeg-devel mailing list