[FFmpeg-devel] [PATCH 05/11] avcodec/mpegenc: do not use unquantize shortcuts for wmv1

James Darnley jdarnley at obe.tv
Tue Jun 20 13:58:48 EEST 2017


On 2017-06-20 00:08, Michael Niedermayer wrote:
> On Mon, Jun 19, 2017 at 05:10:58PM +0200, James Darnley wrote:
>> From: "Ronald S. Bultje" <rsbultje at gmail.com>
>>
>> Commit message by James Darnley
>>
>> The shortcut is based on end-of-block positions.  This leads to some
>> coefficients not being unquantized.  This is the symptom of the bug.
>>
> 
>> A possible candidate for the real bug is the scan table used here in
>> unquantize does not appear to match the one used in wmv1.  That might be
>> because h263_unquantize_intra uses the inter scan table.
> 
> changed it to intra, i hope this makes this patch here unneeded

Yes it does appear to be unneeded.  Thank you.



More information about the ffmpeg-devel mailing list