[FFmpeg-devel] [PATCH 1/2] avcodec/mpegvideo: Use intra_scantable in dct_unquantize_h263_intra_c()

Michael Niedermayer michael at niedermayer.cc
Wed Jun 21 00:06:34 EEST 2017


On Tue, Jun 20, 2017 at 12:06:08AM +0000, Kieran Kunhya wrote:
> On Tue, 20 Jun 2017, 00:38 Michael Niedermayer, <michael at niedermayer.cc>
> wrote:
> 
> > Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> > ---
> >  libavcodec/mpegvideo.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/libavcodec/mpegvideo.c b/libavcodec/mpegvideo.c
> > index 63a30b93ce..e29558b3a2 100644
> > --- a/libavcodec/mpegvideo.c
> > +++ b/libavcodec/mpegvideo.c
> > @@ -225,7 +225,7 @@ static void dct_unquantize_h263_intra_c(MpegEncContext
> > *s,
> >      if(s->ac_pred)
> >          nCoeffs=63;
> >      else
> > -        nCoeffs= s->inter_scantable.raster_end[ s->block_last_index[n] ];
> > +        nCoeffs= s->intra_scantable.raster_end[ s->block_last_index[n] ];
> >
> >      for(i=1; i<=nCoeffs; i++) {
> >          level = block[i];
> > --
> > 2.13.0
> >
> 
> Are you able to document some of this, Ronald and James spent a lot of time
> trying to understand this undocumented code and this patch set doesn't
> explain anything better.

can you be more specific about what should be documented ?
Iam a little "handicapped" as i wrote or know large parts of this
stuff, so i do not realize what is hard to understand ...

I think mpegvideo would benefit from some cleanup.
Ideally code should not need documentation in most cases


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The worst form of inequality is to try to make unequal things equal.
-- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170620/12298a14/attachment.sig>


More information about the ffmpeg-devel mailing list